[OSX] HybridGlobalization implement locale native functions#84417
Merged
[OSX] HybridGlobalization implement locale native functions#84417
Conversation
ghost
assigned
|
Tagging subscribers to this area: @dotnet/area-system-globalization Issue DetailsImplemented following native functions for OSX platforms
Contributes to #80689
|
|
Tagging subscribers to 'os-ios': @steveisok, @akoeplinger Issue DetailsImplemented following native functions for OSX platforms
Contributes to #80689
|
|
Tagging subscribers to 'os-maccatalyst': @steveisok, @akoeplinger Issue DetailsImplemented following native functions for OSX platforms
Contributes to #80689
|
ilonatommy
reviewed
Apr 6, 2023
Member
ilonatommy
left a comment
ilonatommy
left a comment
There was a problem hiding this comment.
Shallow review: looks good. I did not read the logic yet, I will make a 2nd round soon.
src/libraries/System.Private.CoreLib/src/System/Globalization/CultureData.OSX.cs
Show resolved
Hide resolved
This was referenced Apr 6, 2023
ilonatommy
reviewed
Apr 7, 2023
Member
ilonatommy
left a comment
ilonatommy
left a comment
There was a problem hiding this comment.
Great job! I will approve when we finish with resolving comments.
src/libraries/System.Private.CoreLib/src/System/Globalization/CultureData.OSX.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Private.CoreLib/src/System/Globalization/CultureData.OSX.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Private.CoreLib/src/System/Globalization/CultureData.OSX.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Private.CoreLib/src/System/Globalization/CultureData.Unix.cs
Outdated
Show resolved
Hide resolved
mdh1418
reviewed
Apr 7, 2023
src/native/libs/System.Globalization.Native/pal_localeStringData.h
Outdated
Show resolved
Hide resolved
src/native/libs/System.Globalization.Native/pal_localeStringData.h
Outdated
Show resolved
Hide resolved
src/native/libs/System.Globalization.Native/pal_locale_internal.h
Outdated
Show resolved
Hide resolved
src/native/libs/System.Globalization.Native/pal_localeNumberData.h
Outdated
Show resolved
Hide resolved
This was referenced Apr 12, 2023
mdh1418
reviewed
Apr 13, 2023
mdh1418
reviewed
Apr 13, 2023
src/native/libs/System.Globalization.Native/pal_locale_internal.h
Outdated
Show resolved
Hide resolved
src/native/libs/System.Globalization.Native/pal_locale_internal.h
Outdated
Show resolved
Hide resolved
src/native/libs/System.Globalization.Native/pal_localeStringData.h
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Failures are not related. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented following native functions for OSX platforms
Contributes to #80689
cc @SamMonoRT