Fix for x86 stublinker handling of optimized GC descs#84861
Merged
VSadov merged 6 commits intodotnet:mainfrom Apr 15, 2023
Merged
Fix for x86 stublinker handling of optimized GC descs#84861VSadov merged 6 commits intodotnet:mainfrom
VSadov merged 6 commits intodotnet:mainfrom
Conversation
ghost
added
the
needs-area-label
VSadov
added
area-VM-coreclr
and removed
needs-area-label
Member
Author
|
It is better to look at changes in "ignore whitespace" mode. It is really a very small change, but something makes the diff not able to align. |
jkotas
reviewed
Apr 15, 2023
jkotas
reviewed
Apr 15, 2023
Comment on lines
+6
to
+9
| public class C0 | ||
| { | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
Suggested change
| public class C0 | |
| { | |
| } |
This can be just replaced with object.
jkotas
reviewed
Apr 15, 2023
VSadov
commented
Apr 15, 2023
Co-authored-by: Jan Kotas <[email protected]>
Member
Author
|
Thanks!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #84694
x86 stublinker expected that an array of structs could not have "all pointers" GC desc.
It is possible now if the element is an "all pointers" struct.