Skip to content

Remove references to P/Invokes and DllImport from resource strings in ComInterfaceGenerator#85178

Merged
jkoritzinsky merged 2 commits intodotnet:mainfrom
jkoritzinsky:resource-string-cleanup
May 20, 2023
Merged

Remove references to P/Invokes and DllImport from resource strings in ComInterfaceGenerator#85178
jkoritzinsky merged 2 commits intodotnet:mainfrom
jkoritzinsky:resource-string-cleanup

Conversation

@jkoritzinsky
Copy link
Member

Our diagnostic messages in ComInterfaceGenerator should reference GeneratedComInterface/ComImport, not LibraryImport/DllImport.

@ghost
Copy link

ghost commented Apr 21, 2023

Tagging subscribers to this area: @dotnet/interop-contrib
See info in area-owners.md if you want to be subscribed.

Issue Details

Our diagnostic messages in ComInterfaceGenerator should reference GeneratedComInterface/ComImport, not LibraryImport/DllImport.

Author: jkoritzinsky
Assignees: jkoritzinsky
Labels:

area-System.Runtime.InteropServices

Milestone: -

@jkoritzinsky jkoritzinsky merged commit 0939905 into dotnet:main May 20, 2023
@jkoritzinsky jkoritzinsky deleted the resource-string-cleanup branch May 20, 2023 06:43
@ghost ghost locked as resolved and limited conversation to collaborators Jun 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-System.Runtime.InteropServices source-generator Indicates an issue with a source generator feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants