Tweak TimeProviderTaskExtensions handling of CreateTimer#85200
Merged
stephentoub merged 1 commit intodotnet:mainfrom Apr 22, 2023
Merged
Tweak TimeProviderTaskExtensions handling of CreateTimer#85200stephentoub merged 1 commit intodotnet:mainfrom
stephentoub merged 1 commit intodotnet:mainfrom
Conversation
Avoid the separate Timer.Change call by tweaking how cleanup happens.
ghost
added
the
needs-area-label
tarekgh
approved these changes
Apr 22, 2023
|
Tagging subscribers to this area: @dotnet/area-system-datetime Issue DetailsAvoid the separate Timer.Change call by tweaking how cleanup happens.
|
tarekgh
removed
the
needs-area-label
danmoseley
reviewed
Apr 27, 2023
| // that the registration is not left dangling. | ||
| // There are race conditions where the timer fires after we have attached the cancellation callback but before the | ||
| // registration is stored in state.Registration, or where cancellation is requested prior to the registration being | ||
| // stored into state.Registration, or where the timer could fire after it's been createdbut before it's been stored |
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid the separate Timer.Change call by tweaking how cleanup happens.