Improve ProbabilisticMap performance for small value sets#85202
Merged
MihaZupan merged 1 commit intodotnet:mainfrom Apr 23, 2023
Merged
Improve ProbabilisticMap performance for small value sets#85202MihaZupan merged 1 commit intodotnet:mainfrom
MihaZupan merged 1 commit intodotnet:mainfrom
Conversation
|
Tagging subscribers to this area: @dotnet/area-system-buffers Issue DetailsSince We could go further with e.g. working with a
|
Member
Author
|
Build failure is known according to Build Analysis |
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since
IndexOfAnyExceptdoes avalue.Contains(c)on every input character, it's faster if the value is at least 8 characters long.We could go further with e.g. working with a
Vector128<ushort>directly instead of calling intoContains, but I don't know how common short inputs will actually be in practice.