Disable mark list optimization if we hit a per region mark list overflow#86508
Disable mark list optimization if we hit a per region mark list overflow#86508cshung merged 1 commit intodotnet:mainfrom
Conversation
|
Tagging subscribers to this area: @dotnet/gc Issue DetailsFixes microsoft/FASTER#835 In case the mark list is overflowed when we
|
Maoni0
left a comment
Maoni0
left a comment
There was a problem hiding this comment.
fix looks fine but please consider not duplicating code in plan_phase.
ghost
added
the
needs-author-action
PeterSolMS
left a comment
PeterSolMS
left a comment
There was a problem hiding this comment.
Looks good to me.
Your solution has the property that once we hit a mark list overflow for one region, we will not use the mark list for any other region, even if it is possible. Given that this is such a rare case anyway, it doesn't seem worthwhile fixing.
cshung
force-pushed
the
public/mark-list-overflow
branch
from
2812a50 to
e23f73d
Compare
ghost
removed
the
needs-author-action
|
this actually compiles? |
cshung
force-pushed
the
public/mark-list-overflow
branch
from
e23f73d to
c82a4fe
Compare
ghost
locked as resolved and limited conversation to collaborators
3 participants
Fixes microsoft/FASTER#835
In case the mark list is overflowed when we
get_region_mark_list, we have to disable the optimization, otherwise, we will miss marking live objects and cause heap corruption.