Skip to content

[release/7.0-staging] #76881 internal properties in GetRuntimeProperties are not shown#87175

Merged
mkhamoyan merged 9 commits intorelease/7.0-stagingfrom
backport/pr-77169-to-release/7.0-staging
Jun 30, 2023
Merged

[release/7.0-staging] #76881 internal properties in GetRuntimeProperties are not shown#87175
mkhamoyan merged 9 commits intorelease/7.0-stagingfrom
backport/pr-77169-to-release/7.0-staging

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Jun 6, 2023 •
edited by ivanpovazan
Loading

Backport of #77169 to release/7.0-staging

/cc @mkhamoyan

Customer Impact

Customers who upgraded from Xamarin to MAUI experienced a difference in reflection behavior when getting all properties from a type. In MAUI, protected properties from a parent class were not returned reported here: #86149

Testing

Added a test that covers this scenario and it passes.

Risk

Low as by this change while getting all properties for a type, the protected properties declared in inherited type will be returned as well.

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

@ghost ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jun 6, 2023
@ghost
Copy link

ghost commented Jun 6, 2023

Tagging subscribers to this area: @dotnet/area-system-reflection
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #77169 to release/7.0-staging

/cc @mkhamoyan

Customer Impact

Testing

Risk

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

area-System.Reflection, needs-area-label
Milestone: -

@mkhamoyan mkhamoyan removed the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jun 6, 2023
This was referenced Jun 6, 2023
Closed
Closed
@lambdageek lambdageek added the Servicing-consider Issue for next servicing release review label Jun 7, 2023
@lambdageek lambdageek added this to the 7.0.x milestone Jun 7, 2023
@ivanpovazan
Copy link
Member

ivanpovazan commented Jun 9, 2023

/azp run runtime-android

@azure-pipelines
Copy link

azure-pipelines bot commented Jun 9, 2023

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@ivanpovazan
Copy link
Member

ivanpovazan commented Jun 9, 2023

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

azure-pipelines bot commented Jun 9, 2023

Azure Pipelines successfully started running 1 pipeline(s).

@build-analysis build-analysis bot mentioned this pull request Jun 9, 2023
Closed
@runfoapp runfoapp bot mentioned this pull request Jun 9, 2023
Open
This was referenced Jun 9, 2023
Closed
Closed
Closed
@carlossanlop
Copy link
Contributor

carlossanlop commented Jun 12, 2023 •
edited
Loading

@mkhamoyan @lambdageek Today is code complete for the July servicing release. Pleaseget a Tactics approval and merge before EOD if you'd like this to be included in the release.

@mkhamoyan
Copy link
Contributor

mkhamoyan commented Jun 13, 2023

/azp run runtime-ioslike

@azure-pipelines
Copy link

azure-pipelines bot commented Jun 13, 2023

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

This was referenced Jun 13, 2023
Closed
Open
@ivanpovazan
Copy link
Member

ivanpovazan commented Jun 13, 2023

@mkhamoyan @lambdageek Today is code complete for the July servicing release. Pleaseget a Tactics approval and merge before EOD if you'd like this to be included in the release.

@carlossanlop thank you very much for the information. However, merging this PR is not urgent and we want to make sure that runtime-extra-platforms failures are not related, so it can wait for the next release.

@mkhamoyan
Copy link
Contributor

mkhamoyan commented Jun 13, 2023

Failures are related to some infrastructure issues

DVTRadarComponentKey=261622, NSLocalizedDescription=The disk image is not allowed to be mounted.}}, NSLocalizedRecoverySuggestion=This operation can fail if the version of the OS on the device is incompatible with the installed version of Xcode. You may also need to restart your Mac and device in order to correctly detect compatibility., NSLocalizedFailure=The disk image is not allowed to be mounted., DVTRadarComponentKey=487927, NSLocalizedDescription=Failed to prepare the device for development.}
[12:54:42.0942470] warning HE0030: Could not mount developer tools on 'DNCENGOSX129': Failed to prepare the device for development.

@leecow leecow added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Jun 13, 2023
@leecow leecow modified the milestones: 7.0.x, 7.0.8 Jun 13, 2023
@ivanpovazan
Copy link
Member

ivanpovazan commented Jun 29, 2023

Shall we try to rerun runtime-extra-platforms or the infrastructure issues are still to-be-fixed?

@mkhamoyan
Copy link
Contributor

mkhamoyan commented Jun 29, 2023

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

azure-pipelines bot commented Jun 29, 2023

Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Jun 29, 2023
Open
Closed
Closed
@mkhamoyan
Copy link
Contributor

mkhamoyan commented Jun 30, 2023

Failing tests are not related to this PR changes.
Test cases that could have been affected are System.Reflection.Tests and System.Reflextion.Extensions.Tests and they are passing.

ivanpovazan
ivanpovazan approved these changes Jun 30, 2023
View reviewed changes
Copy link
Member

@ivanpovazan ivanpovazan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@mkhamoyan mkhamoyan merged commit 2251e9f into release/7.0-staging Jun 30, 2023
@mkhamoyan mkhamoyan deleted the backport/pr-77169-to-release/7.0-staging branch June 30, 2023 13:58
@ivanpovazan ivanpovazan mentioned this pull request Jun 30, 2023
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Jul 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lambdageek lambdageek lambdageek approved these changes

@ivanpovazan ivanpovazan ivanpovazan approved these changes

@vargaz vargaz Awaiting requested review from vargaz

@thaystg thaystg Awaiting requested review from thaystg

Assignees

No one assigned

Labels

area-System.Reflection Servicing-approved Approved for servicing release

Projects

None yet

Milestone

7.0.8

Development

Successfully merging this pull request may close these issues.

6 participants

@ivanpovazan @carlossanlop @mkhamoyan @lambdageek @leecow @steveharter