[mono][interp] Refactor icall opcodes#87269
Merged
BrzVlad merged 8 commits intodotnet:mainfrom Jun 15, 2023
Merged
Conversation
|
Tagging subscribers to this area: @BrzVlad, @kotlarmilos Issue DetailsHaving per signature opcode is overkill. Get rid of these opcodes and refactor so we have a 0 based enum instead for the signature that is passed into the code stream to a generic icall opcode.
|
vargaz
reviewed
Jun 8, 2023
vargaz
approved these changes
Jun 8, 2023
kg
reviewed
Jun 8, 2023
kg
reviewed
Jun 8, 2023
kg
approved these changes
Jun 8, 2023
Member
|
re the build errors you can just remove the entries from the opcode values header. It's fine for opcodes to be missing from that header |
This was referenced Jun 8, 2023
MINT_ICALL_* opcodes are pretty much dead and untested
Having the signature hardcoded in the opcode seems overkill for icalls.
d04d7af to
5bbd003
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having per signature opcode is overkill. Get rid of these opcodes and refactor so we have a 0 based enum instead for the signature that is passed into the code stream to a generic icall opcode.