Disable mark list optimization if we hit a per region mark list overflow (#86508)#87339
Merged
cshung merged 1 commit intodotnet:release/7.0-stagingfrom Jul 10, 2023
Conversation
|
Tagging subscribers to this area: @dotnet/gc Issue Detailsnull
|
Maoni0
approved these changes
Jun 9, 2023
Contributor
Contributor
|
@cshung @Maoni0 this is still marked as draft. Reminder: Code Complete for the August Release is tomorrow Monday July 10th. If you intend to include this fix in that release, please make sure to get a tactics approval and get it merged before 4pm because that's when I'll start the staging merge process into internal. |
jeffschwMSFT
approved these changes
Jul 10, 2023
Member
jeffschwMSFT
left a comment
There was a problem hiding this comment.
approved. we will take for consideration in 7.0.x
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #86508 to release/7.0-staging
Customer Impact
FASTER is a popular open-source key-value store in .NET that has production use within and across Microsoft. This bug is causing a direct impact on the usability of FASTER, for the scenario where instances are created and destroyed frequently. Fixing this will allow the safe use of FASTER in production by both Microsoft and external customers of FASTER.
The root cause of this bug is that under server GC, it is possible for us to run out of memory to store the mark list for a region. In that case, the code before the fix will assume the partially filled mark list as all the marked objects and therefore prematurely release the marked objects that were left out. This change will fix the issue by making sure we don't use the partially filled mark list in case we ran out of space.
Testing
Risk
Low, this change is merged to the main branch for a month now and nothing happened since.