Skip to content

[release/7.0-staging][wasm] CI: Fix EAT/AOT tests build#87546

Merged
radical merged 1 commit intodotnet:release/7.0-stagingfrom
radical:wasm-fix-trimming
Jul 10, 2023
Merged

[release/7.0-staging][wasm] CI: Fix EAT/AOT tests build#87546
radical merged 1 commit intodotnet:release/7.0-stagingfrom
radical:wasm-fix-trimming

Conversation

@radical
Copy link
Member

@radical radical commented Jun 14, 2023 •
edited
Loading

The builds for wasm EAT/AOT tests are broken because building System.Format.Cbor.Tests fails with:

resource ILLink.Substitutions.xml in FSharp.Core, Version=7.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a(5,6): error IL2040: FSharp.Core: Could not find embedded resource 'FSharpSignatureCompressedData.FSharp.Core' to remove in assembly 'FSharp.Core'. [/__w/1/s/src/libraries/System.Formats.Cbor/tests/System.Formats.Cbor.Tests.csproj::TargetFramework=net7.0]
##[error]resource ILLink.Substitutions.xml in FSharp.Core, Version=7.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a(5,6): error IL2040: (NETCORE_ENGINEERING_TELEMETRY=Build) FSharp.Core: Could not find embedded resource 'FSharpSignatureCompressedData.FSharp.Core' to remove in assembly 'FSharp.Core'.
resource ILLink.Substitutions.xml in FSharp.Core, Version=7.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a(3,6): error IL2040: FSharp.Core: Could not find embedded resource 'FSharpOptimizationCompressedData.FSharp.Core' to remove in assembly 'FSharp.Core'. [/__w/1/s/src/libraries/System.Formats.Cbor/tests/System.Formats.Cbor.Tests.csproj::TargetFramework=net7.0]
##[error]resource ILLink.Substitutions.xml in FSharp.Core, Version=7.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a(3,6): error IL2040: (NETCORE_ENGINEERING_TELEMETRY=Build) FSharp.Core: Could not find embedded resource 'FSharpOptimizationCompressedData.FSharp.Core' to remove in assembly 'FSharp.Core'.

Disable failing System.Formats.Cbor.Tests

Issue: #86916

@ghost ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jun 14, 2023
@ghost ghost assigned radical Jun 14, 2023
@radical radical added arch-wasm WebAssembly architecture area-Build-mono test-failure and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Jun 14, 2023
@ghost
Copy link

ghost commented Jun 14, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Disable failing System.Formats.Cbor.Tests

Issue: #86916

Author: radical
Assignees: radical
Labels:

arch-wasm, area-Build-mono, test-failure
Milestone: -

@radical
Copy link
Member Author

radical commented Jun 14, 2023

/azp run runtime-wasm

@azure-pipelines
Copy link

azure-pipelines bot commented Jun 14, 2023

Azure Pipelines successfully started running 1 pipeline(s).

@radical radical changed the title [release/7.0-staging][wasm] Fix EAT/AOT tests build [release/7.0-staging][wasm] CI: Fix EAT/AOT tests build Jun 14, 2023
@radical radical marked this pull request as ready for review June 14, 2023 07:40
This was referenced Jun 14, 2023
Closed
Closed
@radical radical requested a review from carlossanlop June 14, 2023 15:28
@carlossanlop carlossanlop added the Servicing-approved Approved for servicing release label Jul 10, 2023
@carlossanlop
Copy link
Contributor

carlossanlop commented Jul 10, 2023 •
edited
Loading

@radical - Reminder: Code Complete for the August Release is tomorrow Monday July 10th. If you intend to include this fix in that release, please make sure to merge it before 4pm because that's when I'll start the staging merge process into internal.

I approved it and added the required label. Merge if the CI looks good.

@radical
Copy link
Member Author

radical commented Jul 10, 2023

/azp run runtime-wasm-libtests

@azure-pipelines
Copy link

azure-pipelines bot commented Jul 10, 2023

No commit pushedDate could be found for PR 87546 in repo dotnet/runtime

@radical radical merged commit 574b30d into dotnet:release/7.0-staging Jul 10, 2023
@radical radical deleted the wasm-fix-trimming branch July 10, 2023 21:52
@radical radical mentioned this pull request Aug 3, 2023
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Aug 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lewing lewing lewing approved these changes

@pavelsavara pavelsavara pavelsavara approved these changes

@steveisok steveisok Awaiting requested review from steveisok

@maraf maraf Awaiting requested review from maraf

+1 more reviewer

@carlossanlop carlossanlop carlossanlop approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@radical radical

Labels

arch-wasm WebAssembly architecture area-Build-mono Servicing-approved Approved for servicing release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@radical @carlossanlop @lewing @pavelsavara