[mono][debugger] Concurrency on execution context dictionary#87870
Merged
radical merged 4 commits intodotnet:mainfrom Jun 21, 2023
Merged
[mono][debugger] Concurrency on execution context dictionary#87870radical merged 4 commits intodotnet:mainfrom
radical merged 4 commits intodotnet:mainfrom
Conversation
|
Tagging subscribers to this area: @thaystg Issue DetailsFollow up of this #87154
|
radical
reviewed
Jun 21, 2023
| return false; | ||
| if (contextBag.IsEmpty) | ||
| return false; | ||
| executionContext = contextBag.Where(context => context.Id == contextBag.Where(context => context.Destroyed == false).Max(context => context.Id)).FirstOrDefault(); |
Member
There was a problem hiding this comment.
This should work, right? Fine for a follow up PR.
Suggested change
| executionContext = contextBag.Where(context => context.Id == contextBag.Where(context => context.Destroyed == false).Max(context => context.Id)).FirstOrDefault(); | |
| int maxId = contextBag.Where(context => context.Destroyed == false).Max(context => context.Id); | |
| executionContext = contextBag.Where(context => context.Id == maxId).FirstOrDefault(); |
radical
reviewed
Jun 21, 2023
Comment on lines
+561
to
+562
| contexts[workerSessionId] = new(); | ||
| contexts[workerSessionId].Add(context.CreateChildAsyncExecutionContext(workerSessionId)); |
Member
|
Failure is unrelated: |
radical
approved these changes
Jun 21, 2023
thaystg
added a commit
to thaystg/runtime
that referenced
this pull request
Jul 3, 2023
thaystg
added a commit
to thaystg/runtime
that referenced
this pull request
Jul 3, 2023
thaystg
added a commit
that referenced
this pull request
Jul 10, 2023
thaystg
added a commit
that referenced
this pull request
Jul 10, 2023
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up of this #87154