Skip to content

[release/6.0-staging][mono][debugger] Showing "Frame not in module" after vscode-js-debug bump on VS#88351

Merged
thaystg merged 2 commits intodotnet:release/6.0-stagingfrom
thaystg:thays_backport_88336
Jul 10, 2023
Merged

[release/6.0-staging][mono][debugger] Showing "Frame not in module" after vscode-js-debug bump on VS#88351
thaystg merged 2 commits intodotnet:release/6.0-stagingfrom
thaystg:thays_backport_88336

Conversation

@thaystg
Copy link
Member

@thaystg thaystg commented Jul 3, 2023

Backport #87154 #87870 #87979

Customer Impact
Fixes #87407.
ExecutionContextDestroy and ExecutionContextCleared were CDP messages ignored by vscode-js-debug, and now they implemented the correct support for it, so we also need to implement the correct support on BrowserDebugProxy otherwise it will not be possible to debug Blazor apps with authentication.

Testing:
Try setting a breakpoint on a page guarded by authentication.

Risk
Medium, It's removing the debugging contexts that are not valid anymore.

@thaystg thaystg requested a review from marek-safar as a code owner July 3, 2023 18:57
@ghost ghost added the area-Debugger-mono label Jul 3, 2023
@ghost ghost assigned thaystg Jul 3, 2023
@ghost
Copy link

ghost commented Jul 3, 2023

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport #87154 #87870 #87979

Customer Impact
Fixes #87407.
ExecutionContextDestroy and ExecutionContextCleared were CDP messages ignored by vscode-js-debug, and now they implemented the correct support for it, so we also need to implement the correct support on BrowserDebugProxy otherwise it will not be possible to debug Blazor apps with authentication.

Testing:
Try setting a breakpoint on a page guarded by authentication.

Risk
Medium, It's removing the debugging contexts that are not valid anymore.

Author: thaystg
Assignees: thaystg
Labels:

area-Debugger-mono
Milestone: -

@thaystg thaystg added the Servicing-consider Issue for next servicing release review label Jul 3, 2023
@build-analysis build-analysis bot mentioned this pull request Jul 3, 2023
Open
@rbhanda rbhanda added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Jul 6, 2023
@rbhanda rbhanda added this to the 6.0.21 milestone Jul 6, 2023
@carlossanlop
Copy link
Contributor

carlossanlop commented Jul 10, 2023

@thaystg - Reminder - Tomorrow Monday 10th is Code Complete for the August Release. If you intend to get this fix included in that servicing release, please make sure to get an area owner sign-off and merge the PR before 4pm, because that's when I close the branches to start merging staging into internal.

@thaystg thaystg merged commit 9df36d8 into dotnet:release/6.0-staging Jul 10, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Aug 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@radical radical radical approved these changes

@marek-safar marek-safar Awaiting requested review from marek-safar

Assignees

@thaystg thaystg

Labels

area-Debugger-mono Servicing-approved Approved for servicing release

Projects

None yet

Milestone

6.0.21

Development

Successfully merging this pull request may close these issues.

4 participants

@thaystg @carlossanlop @radical @rbhanda