Build native windows-arm64 Mono cross-compilers#89651
Merged
directhex merged 9 commits intodotnet:mainfrom Oct 17, 2023
Merged
Conversation
ghost
closed this
|
Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it. |
directhex
requested review from
BrzVlad,
lambdageek,
lewing,
marek-safar,
radical and
vargaz
as code owners
Contributor
Author
|
Opening to review. This is not tested in Helix - we do not have the means to do so (Helix Windows ARM64 is an unmodified Azure OS image, and there's no such thing as Windows Server ARM64 Docker images which we could add the needed SDKs into the way we do for testing on X64) |
Contributor
|
The runtime changes look ok |
Contributor
Author
|
The relevant job is still passing. If nobody has any objections, this should get approved/merged. |
steveisok
approved these changes
Oct 17, 2023
lambdageek
approved these changes
Oct 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a stub, but ought to build at least.