Change generation for NonGC objects for debugger#89927
Merged
EgorBo merged 7 commits intodotnet:mainfrom Aug 8, 2023
Merged
Conversation
ghost
added
the
|
Tagging subscribers to this area: @tommcdon Issue DetailsIt seems that currently we do expose nongc objects to debugger (via EnumerateHeap API - I've checked that locally): but with two issues:
Presumably, this change requires changes on VS side (and external debuggers if they use this API?)
cc @davmason @noahfalk @cshung @hoyosjs
|
Member
|
For the VS UI it would be more accurate if VS replaced the word "Generations:" with a different term like "Heaps", "Heap Regions", or "Categories". Its in the grey area to call POH or LOH a generation, but hopefully we can avoid implying that NonGC is a generation. |
noahfalk
approved these changes
Aug 4, 2023
hoyosjs
approved these changes
Aug 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems that currently we do expose nongc objects to debugger (via EnumerateHeap API - I've checked that locally):
but with two issues:
Presumably, this change requires changes on VS side (and external debuggers if they use this API?)
cc @davmason @noahfalk @cshung @hoyosjs