Revert "Update perf run yaml with changes for crank on helix (#90368)"#90424
Merged
radical merged 1 commit intodotnet:mainfrom Aug 11, 2023
Merged
Revert "Update perf run yaml with changes for crank on helix (#90368)"#90424radical merged 1 commit intodotnet:mainfrom
radical merged 1 commit intodotnet:mainfrom
Conversation
…90368)" This reverts commit bbe40f8. This caused perf pipeline runs to break. Issue: dotnet#90420
ghost
added
the
Member
Author
|
Staging this, in case the proper fix will take time. |
radical
added
area-Infrastructure
and removed
arch-wasm
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
radical
added
the
perf-pipeline
Contributor
|
Reverting this change will break as well unless we revert the changes in the performance repository too, I will work on a proper fix right now |
radical
added
the
NO-MERGE
radical
removed
the
NO-MERGE
Contributor
|
I have made a PR to performance that removes the dependency on dataclasses library so that we can continue with this PR and revert the changes: dotnet/performance#3251 |
caaavik-msft
approved these changes
Aug 11, 2023
Member
Author
|
This will not get tested by CI here. Merging it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit bbe40f8.
This caused perf pipeline runs to break. But dotnet/performance#3251 from @caaavik-msft, along with this revert will fix the issue.
Issue: #90420