[RISC-V] Fix MarshalStructAsLayoutSeq#90719
Merged
jakobbotsch merged 3 commits intodotnet:mainfrom Aug 29, 2023
Merged
Conversation
- Fix MarshalStructAsParam_AsSeqByValFixedBufferClassificationTest - Fix MarshalStructAsParam_AsSeqByValUnicodeCharArrayClassification
ghost
added
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue Details
Part of #84834
|
Member
Author
|
@jakobbotsch Could you take a look at this PR? Thank you so much. |
tomeksowi
approved these changes
Aug 23, 2023
alpencolt
approved these changes
Aug 24, 2023
jakobbotsch
reviewed
Aug 24, 2023
t-mustafin
approved these changes
Aug 28, 2023
tomeksowi
approved these changes
Aug 29, 2023
jakobbotsch
approved these changes
Aug 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ex. Argument in
struct { int a, int b, float c}type should be passed with two integer registers (not one integer register and one float register).Part of #84834
cc @wscho77 @HJLeee @JongHeonChoi @t-mustafin @alpencolt @gbalykov @tomeksowi