Fix invalid PGO optimization path on Nuget cache containing spaces.#90729
Fix invalid PGO optimization path on Nuget cache containing spaces.#90729kunalspathak merged 1 commit intodotnet:mainfrom
Conversation
Since CMD does not strip quotes from arguments passed in with quotes by default, if a Nuget package cache path containing a space is passed to build-runtime.cmd, it will pass it into an additional CMake argument with an additional set of quotes. This causes string semantics to be disabled upon reaching the second opening quote, thus separating the cache path into two separate arguments incorrectly, resulting in the PGO data optimization pointing to an invalid path. This patch fixes this issue by simply removing the redundant quotes when accepting the arguments in build-runtime.cmd.
ghost
added
area-Infrastructure-coreclr
community-contribution
|
Tagging subscribers to this area: @hoyosjs Issue DetailsSince CMD does not strip quotes from arguments passed in with quotes by default, if a Nuget package cache path containing a space is passed to This causes string semantics to be disabled upon reaching the second opening quote, thus separating the cache path into two separate arguments incorrectly, resulting in the PGO data optimization pointing to an invalid path. This patch fixes this issue by simply removing the redundant quotes when accepting the arguments in
|
|
We (Arm) saw this issue when doing testing directly on a Windows On Arm box. |
|
Looks like the |
ghost
locked as resolved and limited conversation to collaborators
3 participants
Since CMD does not strip quotes from arguments passed in with quotes by default, if a Nuget package cache path containing a space is passed to
build-runtime.cmd, it will pass it into an additional CMake argument with an additional set of quotes.This causes string semantics to be disabled upon reaching the second opening quote, thus separating the cache path into two separate arguments incorrectly, resulting in the PGO data optimization pointing to an invalid path.
This patch fixes this issue by simply removing the redundant quotes when accepting the arguments in
build-runtime.cmd.