Skip to content

[iOS][non-icu] HybridGlobalization implement timezoneinfo functions#91458

Merged
mkhamoyan merged 15 commits intodotnet:mainfrom
mkhamoyan:hybrid_timezone_changes
Sep 7, 2023
Merged

[iOS][non-icu] HybridGlobalization implement timezoneinfo functions#91458
mkhamoyan merged 15 commits intodotnet:mainfrom
mkhamoyan:hybrid_timezone_changes

Conversation

@mkhamoyan
Copy link
Contributor

@mkhamoyan mkhamoyan commented Sep 1, 2023

Implement timezoneinfo for hybrid mode on Apple platforms

Contributes to #80689

cc @SamMonoRT

@ghost ghost assigned mkhamoyan Sep 1, 2023
@ghost
Copy link

ghost commented Sep 1, 2023

Tagging subscribers to this area: @dotnet/area-system-globalization
See info in area-owners.md if you want to be subscribed.

Issue Details

Implement timezoneinfo for hybrid mode on Apple platforms

Contributes to #80689

cc @SamMonoRT

Author: mkhamoyan
Assignees: -
Labels:

area-System.Globalization
Milestone: -

@mkhamoyan mkhamoyan added os-ios Apple iOS os-tvos Apple tvOS labels Sep 1, 2023
@ghost
Copy link

ghost commented Sep 1, 2023

Tagging subscribers to 'os-ios': @steveisok, @akoeplinger, @kotlarmilos
See info in area-owners.md if you want to be subscribed.

Issue Details

Implement timezoneinfo for hybrid mode on Apple platforms

Contributes to #80689

cc @SamMonoRT

Author: mkhamoyan
Assignees: mkhamoyan
Labels:

area-System.Globalization, os-ios
Milestone: -

@mkhamoyan
Copy link
Contributor Author

mkhamoyan commented Sep 1, 2023

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

azure-pipelines bot commented Sep 1, 2023

Azure Pipelines successfully started running 1 pipeline(s).

@mkhamoyan
Copy link
Contributor Author

mkhamoyan commented Sep 1, 2023

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

azure-pipelines bot commented Sep 1, 2023

Azure Pipelines successfully started running 1 pipeline(s).

@mkhamoyan mkhamoyan marked this pull request as ready for review September 1, 2023 14:30
This was referenced Sep 1, 2023
Closed
Closed
Closed
Closed
@mkhamoyan
Copy link
Contributor Author

mkhamoyan commented Sep 5, 2023

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

azure-pipelines bot commented Sep 5, 2023

Azure Pipelines successfully started running 1 pipeline(s).

mdh1418
mdh1418 reviewed Sep 5, 2023
View reviewed changes
@build-analysis build-analysis bot mentioned this pull request Sep 5, 2023
Open
@mkhamoyan
Copy link
Contributor Author

mkhamoyan commented Sep 6, 2023

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

azure-pipelines bot commented Sep 6, 2023

Azure Pipelines successfully started running 1 pipeline(s).

@mkhamoyan mkhamoyan requested a review from mdh1418 September 6, 2023 08:47
@mkhamoyan
Copy link
Contributor Author

mkhamoyan commented Sep 6, 2023

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

azure-pipelines bot commented Sep 6, 2023

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines
Copy link

azure-pipelines bot commented Sep 6, 2023

Azure Pipelines successfully started running 1 pipeline(s).

@build-analysis build-analysis bot mentioned this pull request Sep 6, 2023
Closed
mdh1418
mdh1418 approved these changes Sep 6, 2023
View reviewed changes
Copy link
Member

@mdh1418 mdh1418 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me after addressing the remaining comments! Thanks

@mkhamoyan
Copy link
Contributor Author

mkhamoyan commented Sep 6, 2023

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

azure-pipelines bot commented Sep 6, 2023

Azure Pipelines successfully started running 1 pipeline(s).

@build-analysis build-analysis bot mentioned this pull request Sep 7, 2023
Closed
@mkhamoyan
Copy link
Contributor Author

mkhamoyan commented Sep 7, 2023

Failures are not related.

@mkhamoyan mkhamoyan merged commit a76527d into dotnet:main Sep 7, 2023
@mkhamoyan mkhamoyan deleted the hybrid_timezone_changes branch September 7, 2023 09:25
@mkhamoyan mkhamoyan mentioned this pull request Sep 7, 2023
Closed
23 tasks
@mdh1418 mdh1418 mentioned this pull request Sep 7, 2023
Closed
@build-analysis build-analysis bot mentioned this pull request Sep 7, 2023
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Oct 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mdh1418 mdh1418 mdh1418 approved these changes

@steveisok steveisok Awaiting requested review from steveisok steveisok is a code owner

@vargaz vargaz Awaiting requested review from vargaz

@lambdageek lambdageek Awaiting requested review from lambdageek

@SamMonoRT SamMonoRT Awaiting requested review from SamMonoRT

@akoeplinger akoeplinger Awaiting requested review from akoeplinger

Assignees

@mkhamoyan mkhamoyan

Labels

area-System.Globalization os-ios Apple iOS os-tvos Apple tvOS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mkhamoyan @akoeplinger @mdh1418