ARM64: Fix Vector64x2/3/4 API comments. Minor cleanup in AdvSimd.#94188
Merged
TIHan merged 2 commits intodotnet:mainfrom Oct 31, 2023
Merged
ARM64: Fix Vector64x2/3/4 API comments. Minor cleanup in AdvSimd.#94188TIHan merged 2 commits intodotnet:mainfrom
TIHan merged 2 commits intodotnet:mainfrom
Conversation
|
Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics Issue DetailsThis is a non-functional change. It fixes a few comments in the recent VectorLoad APIs that we added, and does some minor cleanup in AdvSimd by removing the fully qualified use of Vector64 and Vector128.
|
Contributor
Author
|
@dotnet/jit-contrib @kunalspathak this is ready. |
kunalspathak
approved these changes
Oct 30, 2023
Contributor
kunalspathak
left a comment
kunalspathak
left a comment
There was a problem hiding this comment.
LGTM. Thanks for cleaning it up.
This was referenced Oct 31, 2023
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a non-functional change. It fixes a few comments in the recent VectorLoad APIs that we added, and does some minor cleanup in AdvSimd by removing the fully qualified use of Vector64 and Vector128.