[wasm] Enable MT in S.Linq.Parallel#96215
Merged
radekdoulik merged 22 commits intodotnet:mainfrom Jan 11, 2024
Merged
Conversation
Also fix the csproj condition to detect FeatureWasmThreads
ghost
added
the
|
Tagging subscribers to this area: @dotnet/area-system-linq-parallel Issue DetailsAlso fix the csproj condition to set the
|
Member
Author
|
This depends on another MT areas to complete, like S.T.Monitor |
Member
Author
|
With the missing pieces in place, we pass the build. During the test run the previously failing test passes, the next one dead locks. More to fix. |
|
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsAlso fix the csproj condition to set the
|
This reverts commit aedafd3.
radekdoulik
changed the title
Member
Author
|
Remaining work in this area, to be added in following PRs
|
pavelsavara
approved these changes
Jan 11, 2024
tmds
pushed a commit
to tmds/runtime
that referenced
this pull request
Jan 23, 2024
Add System.Threading.WebAssembly.Threading ref assembly to enable more parts of threading API on wasm Fix System.Linq.Parallel assembly to work as MT on wasm Increase the initial thread pool size to 7 to let the System.Linq.Parallel tests pass Fixes dotnet#91661 * [wasm] Enable more MT PLinq areas Also fix the csproj condition to detect FeatureWasmThreads * Add missing pieces * Add System.Threading.WebAssembly.Threading.csproj * Fix System.Threading to work with the new wasm MT ref assembly * Enable the failing test * Use the new ref assembly in the System.Linq.Parallel * Remove now obsolete API check supressions * Increase the thread pool size to make the plinq tests pass * Add API check suppressions for System.Threading * Always use the API suppressions for System.Threading * Remove unwanted attributes from the implementation * Add suppressions to corelib * Revert "Remove unwanted attributes from the implementation" This reverts commit aedafd3. * Build fixes * Remove unnecessary suppression * Remove unwanted source file from the list
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add System.Threading.WebAssembly.Threading ref assembly to enable more parts of threading API on wasm
Fix System.Linq.Parallel assembly to work as MT on wasm
Increase the initial thread pool size to 7 to let the System.Linq.Parallel tests pass
Fixes #91661