enforce FIELD_OFFSET_LAST_REAL_OFFSET size limit for InlineArrays#97403
enforce FIELD_OFFSET_LAST_REAL_OFFSET size limit for InlineArrays#97403VSadov merged 1 commit intodotnet:mainfrom
Conversation
lambdageek
left a comment
There was a problem hiding this comment.
(I'm still learning about the CoreCLR type system) CoreCLR bits lgtm
|
Is this fixing the silent overflow in sequential layout too? #95193 (comment) |
No. We can fix that, but it should probably be a separate change. |
|
I've logged an issue to follow up with other silent overflows in sequential layout: #97412 |
|
Added When you commit this breaking change:
Tagging @dotnet/compat for awareness of the breaking change. |
|
@lambdageek - while not strictly necessary, it may make sense to increase the limit on Mono as well. I am not sure if Mono has some other limits for the size of a struct. If such limit is lower, it might make sense to have a different limit. |
|
Thanks!! |
|
/backport to release/8.0-staging |
|
Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/7663297851 |
Fixes: #95193
FIELD_OFFSET_LAST_REAL_OFFSET