[JsonSerializer] Add support for out-of-order metadata reads.#97474
Merged
eiriktsarpalis merged 5 commits intodotnet:mainfrom Feb 2, 2024
Merged
[JsonSerializer] Add support for out-of-order metadata reads.#97474eiriktsarpalis merged 5 commits intodotnet:mainfrom
eiriktsarpalis merged 5 commits intodotnet:mainfrom
Conversation
ghost
added
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
|
Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis Issue DetailsMakes the following changes:
Fix #72604.
|
eiriktsarpalis
added
the
NO-MERGE
Member
Author
|
New API pending approval, please do not merge yet. |
eiriktsarpalis
commented
Jan 24, 2024
...ies/System.Text.Json/tests/Common/ReferenceHandlerTests/ReferenceHandlerTests.Deserialize.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jan 24, 2024
src/libraries/System.Text.Json/Common/JsonSourceGenerationOptionsAttribute.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jan 24, 2024
...tem/Text/Json/Serialization/Converters/Object/ObjectWithParameterizedConstructorConverter.cs
Outdated
Show resolved
Hide resolved
jozkee
reviewed
Jan 25, 2024
...es/System.Text.Json/src/System/Text/Json/Serialization/JsonSerializer.Read.HandleMetadata.cs
Outdated
Show resolved
Hide resolved
...ies/System.Text.Json/tests/Common/ReferenceHandlerTests/ReferenceHandlerTests.Deserialize.cs
Outdated
Show resolved
Hide resolved
...xt.Json/tests/System.Text.Json.Tests/Serialization/PolymorphicTests.CustomTypeHierarchies.cs
Outdated
Show resolved
Hide resolved
3 tasks
eiriktsarpalis
removed
the
NO-MERGE
stephentoub
approved these changes
Jan 30, 2024
This was referenced Jan 31, 2024
eiriktsarpalis
force-pushed
the
feature/json-metadata-readahead
branch
from
1001f4c to
4b6b478
Compare
eiriktsarpalis
commented
Feb 1, 2024
This was referenced Feb 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the following changes:
Fix #72604.