Reduce tolerances for floating point types in TP tests.#99023
Merged
eiriktsarpalis merged 4 commits intodotnet:mainfrom Feb 29, 2024
Merged
Reduce tolerances for floating point types in TP tests.#99023eiriktsarpalis merged 4 commits intodotnet:mainfrom
eiriktsarpalis merged 4 commits intodotnet:mainfrom
Conversation
ghost
added
the
|
Tagging subscribers to this area: @dotnet/area-system-numerics Issue DetailsIncreases the default tolerances to 15 digits for Contributes to #98861.
|
eiriktsarpalis
commented
Feb 27, 2024
eiriktsarpalis
commented
Feb 27, 2024
src/libraries/System.Numerics.Tensors/tests/TensorPrimitives.Generic.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Feb 29, 2024
stephentoub
approved these changes
Feb 29, 2024
eiriktsarpalis
changed the title
eiriktsarpalis
force-pushed
the
tp-increase-test-tolerances
branch
from
917b708 to
38c23c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduces the default tolerances to 15 digits for
double, 6 digits forfloatand 4 digits forHalf. Reworks the test cases such that tolerances can be overridden individually for each floating point type. The goal of this PR is to better quantify which TP methods deviate from the scalar implementations precision-wise.Contributes to #98861.