Remove or document Unsafe.AsPointer uses in core libraries#99146
Merged
jkotas merged 14 commits intodotnet:mainfrom Mar 5, 2024
Merged
Remove or document Unsafe.AsPointer uses in core libraries#99146jkotas merged 14 commits intodotnet:mainfrom
jkotas merged 14 commits intodotnet:mainfrom
Conversation
- Also add internal helper method Unsafe.IsOpportunisticallyAligned - And cast a pointer to IntPtr instead of int for a unit test
ghost
added
the
|
Tagging subscribers to this area: @dotnet/area-system-memory Issue DetailsContributes to #99144
|
huoyaoyuan
reviewed
Mar 1, 2024
src/libraries/System.Memory/tests/ArrayBufferWriter/ArrayBufferWriterTests.T.cs
Show resolved
Hide resolved
Member
|
Many tests are failing with |
jkotas
reviewed
Mar 1, 2024
src/libraries/System.Memory/tests/MemoryMarshal/CreateFromPinnedArray.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Mar 1, 2024
src/libraries/System.Private.CoreLib/src/System/Runtime/CompilerServices/Unsafe.cs
Show resolved
Hide resolved
src/libraries/System.Private.CoreLib/src/System/Runtime/CompilerServices/Unsafe.cs
Outdated
Show resolved
Hide resolved
- Other than MethodHandle code for NativeAOT - Add Unsafe.OpportunisticMisalignment
hamarb123
changed the title
Contributor
Author
|
I've skipped the code in NativeAOT's |
jkotas
approved these changes
Mar 4, 2024
...ate.CoreLib/src/System/Diagnostics/Tracing/NativeRuntimeEventSource.Threading.NativeSinks.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Mar 4, 2024
src/libraries/System.Private.CoreLib/src/System/Runtime/CompilerServices/Unsafe.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Mar 4, 2024
src/coreclr/nativeaot/Common/src/Internal/Runtime/CompilerHelpers/StartupCodeHelpers.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Private.CoreLib/src/System/Runtime/CompilerServices/Unsafe.cs
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Should I include changes for the misc tests in this PR too? |
Member
I would start a new PR for these. |
sharwell
reviewed
Mar 4, 2024
jkotas
reviewed
Mar 4, 2024
jkotas
reviewed
Mar 4, 2024
src/libraries/System.Private.CoreLib/src/System/Threading/Tasks/TplEventSource.cs
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to #99144