Convert GetCurrentMethod to QCALL#99852
Merged
jkotas merged 3 commits intodotnet:mainfrom Mar 17, 2024
Merged
Conversation
This has a similar structure to FailFast as converted in dotnet#98908. Contributes to dotnet#95695
jkotas
reviewed
Mar 16, 2024
src/coreclr/System.Private.CoreLib/src/System/RuntimeHandles.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Jan Kotas <[email protected]>
Member
|
I see about 6% perf regression in The implementation of |
Contributor
Author
|
I was able to reproduce the regression in a benchmark. Interestingly, it appears that something between .NET 9 Preview 2 and the merge base sped things up:
Anyways, I'll mark this as draft while I fix the regression. |
Co-authored-by: Jan Kotas <[email protected]>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has a similar structure to
FailFastas converted in #98908.Contributes to #95695