Skip to content

Fixed interactive snippet to be runnable in browser#3

Merged
BillWagner merged 1 commit intodotnet:masterfrom
pkulikov:patch-1
Apr 2, 2018
Merged

Fixed interactive snippet to be runnable in browser#3
BillWagner merged 1 commit intodotnet:masterfrom
pkulikov:patch-1

Conversation

@pkulikov
Copy link
Contributor

@pkulikov pkulikov commented Mar 31, 2018

The last code example at the string interpolation article doesn't run because System.Globalization namespace is unknown. I've updated the snippet code to include that dependency.

By the way, when I edit the code in browser by adding the first line

using System.Globalization;

interactive example works.

@BillWagner please review.

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this and fixing it @pkulikov
I'll :shipit: now.

Now that the samples are split from the docs repo, it takes a bit longer to get everything published. We're still building the automated workflow for that.

You should see the changes later this week.

Thanks again for contributing.

@BillWagner BillWagner merged commit b627bec into dotnet:master Apr 2, 2018
@pkulikov pkulikov deleted the patch-1 branch April 2, 2018 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants