Skip to content
This repository was archived by the owner on Sep 13, 2022. It is now read-only.

Add string overloads to DbDataReader.Get*()#1290

Merged
wtgodbe merged 2 commits intodotnet:masterfrom
roji:DbDataReaderStringOverloads
Jul 2, 2019
Merged

Add string overloads to DbDataReader.Get*()#1290
wtgodbe merged 2 commits intodotnet:masterfrom
roji:DbDataReaderStringOverloads

Conversation

@roji
Copy link
Member

@roji roji commented Jun 28, 2019

See https://github.com/dotnet/corefx/issues/31595

This is the 3rd and last in this batch of System.Data changes.

Note that for the naming and namespace for the new DataReaderExtensions class, see dotnet/corefx#36123 (comment) and dotnet/corefx#36123 (comment).

@roji roji requested review from a team as code owners June 28, 2019 12:11
@roji
Copy link
Member Author

roji commented Jun 28, 2019

/cc @divega @terrajobst

marek-safar
marek-safar reviewed Jun 28, 2019
View reviewed changes
@terrajobst
Copy link

terrajobst commented Jul 1, 2019

Tagging @agocke

@terrajobst terrajobst added the netstandard-api This tracks requests for standardizing APIs. label Jul 2, 2019
@terrajobst terrajobst added this to the .NET Standard 2.1 milestone Jul 2, 2019
@terrajobst
Copy link

terrajobst commented Jul 2, 2019

@roji

Please resolve the merge conflicts by doing this:

git checkout master
git pull
git checkout DbDataReaderStringOverloads
git rebase master
git reset src/netstandard/src/ApiCompatBaseline.*
git checkout src/netstandard/src/ApiCompatBaseline.*
.\build.cmd
git add .
git rebase --continue
git push origin DbDataReaderStringOverloads -f

@wtgodbe
Copy link
Member

wtgodbe commented Jul 2, 2019

Approved for preview7

@wtgodbe wtgodbe merged commit bceac69 into dotnet:master Jul 2, 2019
wtgodbe pushed a commit to wtgodbe/standard that referenced this pull request Jul 2, 2019
@roji @wtgodbe
Add string overloads to DbDataReader.Get*() (dotnet#1290)
98833d7 
See https://github.com/dotnet/corefx/issues/31595
@wtgodbe wtgodbe mentioned this pull request Jul 2, 2019
Merged
@roji roji mentioned this pull request Jul 2, 2019
Merged
@wtgodbe wtgodbe mentioned this pull request Jul 8, 2019
Merged
@divega divega mentioned this pull request Jul 20, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

5 more reviewers

@divega divega divega left review comments

@terrajobst terrajobst terrajobst approved these changes

@joshpeterson joshpeterson joshpeterson approved these changes

@marek-safar marek-safar marek-safar approved these changes

@clairernovotny clairernovotny clairernovotny approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

netstandard-api This tracks requests for standardizing APIs.

Projects

None yet

Milestone

.NET Standard 2.1

Development

Successfully merging this pull request may close these issues.

7 participants

@roji @terrajobst @wtgodbe @joshpeterson @marek-safar @divega @clairernovotny