[main] Update dependencies from dotnet/runtime by dotnet-maestro[bot] · Pull Request #7578 · dotnet/winforms

dotnet-maestro · 2022-08-11T12:11:53Z

This pull request updates the following dependencies

From https://github.com/dotnet/runtime

Subscription: d9f5b309-084f-43b5-02de-08d8b80548e4
Build: 20220814.6
Date Produced: August 15, 2022 9:35:05 AM UTC
Commit: e680411c22e33f45821f4ae64365a2970b2430a6
Branch: refs/heads/main

Updates:
- Microsoft.Internal.Runtime.WindowsDesktop.Transport: from 7.0.0-rc.1.22410.1 to 7.0.0-rc.1.22414.6
- Microsoft.NET.Sdk.IL: from 7.0.0-rc.1.22410.1 to 7.0.0-rc.1.22414.6
- Microsoft.NETCore.App.Ref: from 7.0.0-rc.1.22410.1 to 7.0.0-rc.1.22414.6
- Microsoft.NETCore.App.Runtime.win-x64: from 7.0.0-rc.1.22410.1 to 7.0.0-rc.1.22414.6
- Microsoft.NETCore.ILAsm: from 7.0.0-rc.1.22410.1 to 7.0.0-rc.1.22414.6
- Microsoft.NETCore.ILDAsm: from 7.0.0-rc.1.22410.1 to 7.0.0-rc.1.22414.6
- Microsoft.NETCore.Platforms: from 7.0.0-rc.1.22410.1 to 7.0.0-rc.1.22414.6
- Microsoft.Win32.Registry.AccessControl: from 7.0.0-rc.1.22410.1 to 7.0.0-rc.1.22414.6
- Microsoft.Win32.SystemEvents: from 7.0.0-rc.1.22410.1 to 7.0.0-rc.1.22414.6
- Microsoft.Windows.Compatibility: from 7.0.0-rc.1.22410.1 to 7.0.0-rc.1.22414.6
- runtime.win-x64.Microsoft.NETCore.ILAsm: from 7.0.0-rc.1.22410.1 to 7.0.0-rc.1.22414.6
- runtime.win-x86.Microsoft.NETCore.ILAsm: from 7.0.0-rc.1.22410.1 to 7.0.0-rc.1.22414.6
- System.CodeDom: from 7.0.0-rc.1.22410.1 to 7.0.0-rc.1.22414.6
- System.Configuration.ConfigurationManager: from 7.0.0-rc.1.22410.1 to 7.0.0-rc.1.22414.6
- System.Diagnostics.EventLog: from 7.0.0-rc.1.22410.1 to 7.0.0-rc.1.22414.6
- System.Diagnostics.PerformanceCounter: from 7.0.0-rc.1.22410.1 to 7.0.0-rc.1.22414.6
- System.DirectoryServices: from 7.0.0-rc.1.22410.1 to 7.0.0-rc.1.22414.6
- System.Drawing.Common: from 7.0.0-rc.1.22410.1 to 7.0.0-rc.1.22414.6
- System.IO.Packaging: from 7.0.0-rc.1.22410.1 to 7.0.0-rc.1.22414.6
- System.Reflection.MetadataLoadContext: from 7.0.0-rc.1.22410.1 to 7.0.0-rc.1.22414.6
- System.Resources.Extensions: from 7.0.0-rc.1.22410.1 to 7.0.0-rc.1.22414.6
- System.Security.Cryptography.Pkcs: from 7.0.0-rc.1.22410.1 to 7.0.0-rc.1.22414.6
- System.Security.Cryptography.ProtectedData: from 7.0.0-rc.1.22410.1 to 7.0.0-rc.1.22414.6
- System.Security.Cryptography.Xml: from 7.0.0-rc.1.22410.1 to 7.0.0-rc.1.22414.6
- System.Security.Permissions: from 7.0.0-rc.1.22410.1 to 7.0.0-rc.1.22414.6
- System.Text.Encodings.Web: from 7.0.0-rc.1.22410.1 to 7.0.0-rc.1.22414.6
- System.Text.Json: from 7.0.0-rc.1.22410.1 to 7.0.0-rc.1.22414.6
- System.Threading.AccessControl: from 7.0.0-rc.1.22410.1 to 7.0.0-rc.1.22414.6
- System.Windows.Extensions: from 7.0.0-rc.1.22410.1 to 7.0.0-rc.1.22414.6
- VS.Redist.Common.NetCore.SharedFramework.x64.7.0: from 7.0.0-rc.1.22410.1 to 7.0.0-rc.1.22414.6

Microsoft Reviewers: Open in CodeFlow

…0810.9 Microsoft.Internal.Runtime.WindowsDesktop.Transport , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , Microsoft.NETCore.ILDAsm , Microsoft.NETCore.Platforms , Microsoft.Win32.Registry.AccessControl , Microsoft.Win32.SystemEvents , Microsoft.Windows.Compatibility , runtime.win-x64.Microsoft.NETCore.ILAsm , runtime.win-x86.Microsoft.NETCore.ILAsm , System.CodeDom , System.Configuration.ConfigurationManager , System.Diagnostics.EventLog , System.Diagnostics.PerformanceCounter , System.DirectoryServices , System.Drawing.Common , System.IO.Packaging , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.Text.Encodings.Web , System.Text.Json , System.Threading.AccessControl , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.7.0 From Version 7.0.0-rc.1.22410.1 -> To Version 7.0.0-rc.1.22410.9

ghost

Go, you big red fire engine!

RussKie · 2022-08-11T23:31:03Z

It is building on the CI as well, but looks like a VB related test Microsoft.VisualBasic.Logging.Tests.LogTests.Write is failing:

Error message
System.NullReferenceException : Object reference not set to an instance of an object.


Stack trace
   at Microsoft.VisualBasic.Logging.Tests.LogTests.Write() in /_/src/Microsoft.VisualBasic/tests/UnitTests/Microsoft/VisualBasic/Logging/LogTests.cs:line 24
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
   at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)

Tanya-Solyanik · 2022-08-12T00:54:40Z

@steveharter , it seems that winforms test failure is related to dotnet/runtime#73087 - if TraceSource is initialized from the config file, it does not initialize the default file listener, and test expects the default listener to be initialized. I suspect winforms should come up with a different way to detect initialization from a config fie, could you please suggest one?

KlausLoeffelmann · 2022-08-12T07:11:23Z

@steveharter, @Tanya-Solyanik:
To be more precise, it is something in the Application Framework for/in Visual Basic, that's causing this, because it does an assumption, which I frankly don't understand:

https://source.dot.net/#Microsoft.VisualBasic.Forms/Microsoft/VisualBasic/Logging/Log.vb,170

This assumption is that when GetSupportedAttributes gets called in a class derived from TraceSource that then would tell that the trace source was configured from a config file. This is not only what DefaultTraceSource does, it seems to be the only reason for it existence. Now, as far as I understand it, after the change, GetSupportAttributes gets called unconditionally, so HasBeenConfigured in the VB AppFramework's DefaultTraceSource returns always true, and so a FileLogTraceListener gets never added, since the Log class assumes, the trace source was configured by a config file. And that's why there will never be a value other than nothing for the DefaultFileLogWriter property.

Now, what I don't understand: Why would (previously) GetSupportedAttributes only have been called, when the trace source was configured by a config file?

…0811.12 Microsoft.Internal.Runtime.WindowsDesktop.Transport , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , Microsoft.NETCore.ILDAsm , Microsoft.NETCore.Platforms , Microsoft.Win32.Registry.AccessControl , Microsoft.Win32.SystemEvents , Microsoft.Windows.Compatibility , runtime.win-x64.Microsoft.NETCore.ILAsm , runtime.win-x86.Microsoft.NETCore.ILAsm , System.CodeDom , System.Configuration.ConfigurationManager , System.Diagnostics.EventLog , System.Diagnostics.PerformanceCounter , System.DirectoryServices , System.Drawing.Common , System.IO.Packaging , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.Text.Encodings.Web , System.Text.Json , System.Threading.AccessControl , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.7.0 From Version 7.0.0-rc.1.22410.1 -> To Version 7.0.0-rc.1.22411.12

…0813.1 Microsoft.Internal.Runtime.WindowsDesktop.Transport , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , Microsoft.NETCore.ILDAsm , Microsoft.NETCore.Platforms , Microsoft.Win32.Registry.AccessControl , Microsoft.Win32.SystemEvents , Microsoft.Windows.Compatibility , runtime.win-x64.Microsoft.NETCore.ILAsm , runtime.win-x86.Microsoft.NETCore.ILAsm , System.CodeDom , System.Configuration.ConfigurationManager , System.Diagnostics.EventLog , System.Diagnostics.PerformanceCounter , System.DirectoryServices , System.Drawing.Common , System.IO.Packaging , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.Text.Encodings.Web , System.Text.Json , System.Threading.AccessControl , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.7.0 From Version 7.0.0-rc.1.22410.1 -> To Version 7.0.0-rc.1.22413.1

…0813.9 Microsoft.Internal.Runtime.WindowsDesktop.Transport , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , Microsoft.NETCore.ILDAsm , Microsoft.NETCore.Platforms , Microsoft.Win32.Registry.AccessControl , Microsoft.Win32.SystemEvents , Microsoft.Windows.Compatibility , runtime.win-x64.Microsoft.NETCore.ILAsm , runtime.win-x86.Microsoft.NETCore.ILAsm , System.CodeDom , System.Configuration.ConfigurationManager , System.Diagnostics.EventLog , System.Diagnostics.PerformanceCounter , System.DirectoryServices , System.Drawing.Common , System.IO.Packaging , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.Text.Encodings.Web , System.Text.Json , System.Threading.AccessControl , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.7.0 From Version 7.0.0-rc.1.22410.1 -> To Version 7.0.0-rc.1.22413.9

…0814.6 Microsoft.Internal.Runtime.WindowsDesktop.Transport , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , Microsoft.NETCore.ILDAsm , Microsoft.NETCore.Platforms , Microsoft.Win32.Registry.AccessControl , Microsoft.Win32.SystemEvents , Microsoft.Windows.Compatibility , runtime.win-x64.Microsoft.NETCore.ILAsm , runtime.win-x86.Microsoft.NETCore.ILAsm , System.CodeDom , System.Configuration.ConfigurationManager , System.Diagnostics.EventLog , System.Diagnostics.PerformanceCounter , System.DirectoryServices , System.Drawing.Common , System.IO.Packaging , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.Text.Encodings.Web , System.Text.Json , System.Threading.AccessControl , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.7.0 From Version 7.0.0-rc.1.22410.1 -> To Version 7.0.0-rc.1.22414.6

dreddy-work · 2022-08-15T20:55:15Z

/azp run

azure-pipelines · 2022-08-15T20:55:29Z

Azure Pipelines successfully started running 2 pipeline(s).

dotnet-maestro bot requested a review from a team as a code owner August 11, 2022 12:11

ghost previously approved these changes Aug 11, 2022

View reviewed changes

Tanya-Solyanik mentioned this pull request Aug 12, 2022

Support TraceSource to be initialized from the app.config file dotnet/runtime#73087

Merged

dotnet-maestro bot dismissed ghost ’s stale review via 968e1e2 August 12, 2022 12:11

dotnet-maestro bot added 3 commits August 13, 2022 12:09

dreddy-work enabled auto-merge (squash) August 15, 2022 21:10

dreddy-work merged commit 17f8241 into main Aug 15, 2022

dreddy-work approved these changes Aug 15, 2022

View reviewed changes

dreddy-work deleted the darc-main-cdeee161-f93a-4716-baf3-0bc17a1d666f branch August 15, 2022 21:26

ghost locked as resolved and limited conversation to collaborators Sep 15, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[main] Update dependencies from dotnet/runtime#7578

[main] Update dependencies from dotnet/runtime#7578
dreddy-work merged 5 commits intomainfrom
darc-main-cdeee161-f93a-4716-baf3-0bc17a1d666f

dotnet-maestro bot commented Aug 11, 2022 •

edited

Loading

Uh oh!

ghost left a comment

Uh oh!

RussKie commented Aug 11, 2022

Uh oh!

Tanya-Solyanik commented Aug 12, 2022

Uh oh!

KlausLoeffelmann commented Aug 12, 2022

Uh oh!

dreddy-work commented Aug 15, 2022

Uh oh!

azure-pipelines bot commented Aug 15, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

dotnet-maestro bot commented Aug 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

From https://github.com/dotnet/runtime

Microsoft Reviewers: Open in CodeFlow

Uh oh!

ghost left a comment

Choose a reason for hiding this comment

Uh oh!

RussKie commented Aug 11, 2022

Uh oh!

Tanya-Solyanik commented Aug 12, 2022

Uh oh!

KlausLoeffelmann commented Aug 12, 2022

Uh oh!

dreddy-work commented Aug 15, 2022

Uh oh!

azure-pipelines bot commented Aug 15, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

dotnet-maestro bot commented Aug 11, 2022 •

edited

Loading