Conversation
filipw
reviewed
Sep 19, 2022
filipw
reviewed
Sep 19, 2022
filipw
approved these changes
Sep 19, 2022
Member
filipw
left a comment
filipw
left a comment
There was a problem hiding this comment.
thanks! let' get rid of 5.0 too
Collaborator
Author
|
@filipw Removed I don't seem to have the permissions to change the settings 😃 |
Member
|
done, thanks!! |
Collaborator
Author
|
Great. I'll release this then?. After that Omnisharp needs to be updated with the latest dotnet-script packages. 👍🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for the upcoming
net7.0which is currently in RC1.Removed support for
netcoreapp3.1netcoreapp3.1reaches EoS (End of Support) on December 13, 2022 and we now supportnet5.0,net6.0andnet7.0.Moved build to Github Actions
The build has been moved from Azure Devops to GitHub Actions. The old build was sort of a mess and a lot was cleaned up here. All jobs now basically have the exact same setup.
OmniSharp
Dotnet.Script.DependencyModelandDotnet.Script.DependencyModel.Nugetneed to be updated in Omnisharp to supportnet7.0. We used to have a framework check inCompilationDependencyResolverwhich was a leftover from when we supportednetcoreapp2.1. This check is now removed meaning that with regards tonetcoreapp3.1which still has a couple of months left, it will still work for resolving compilation dependencies.Versions
The versions has been bumped to 1.4.0 leaving a bit of room if we should need to fix something before
netcoreapp3.1goes out of support.In my opinion we can release this now and get
Dotnet.Script.DependencyModelandDotnet.Script.DependencyModel.Nugetupdated in Omnisharp in good time beforenet7.0goes RTM.Hopefully a new version of OmniSharp will be released by then and we avoid resolving to
latestfor users that wants to start usingnet7.0Build Script
Just a couple of path-related issues where we in the past assumed running the script from the
buildfolder.