Fix height serialization inside script of coinbase input#199
Merged
scravy merged 1 commit intodtr-org:masterfrom Nov 5, 2018
Merged
Conversation
Ported from bitcoin/bitcoin#14633 For bitcoin it's a minor fix as it doesn't cause any problems but as we want to enable height verification from the beginning we need to either fix cpp code or adjust BIP34 and fix tests.
Member
|
Looks good! |
kostyantyn
requested review from
a team,
AM5800,
Gnappuraz,
Ruteri,
frolosofsky and
scravy
scravy
reviewed
Nov 5, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ported from bitcoin/bitcoin#14633
For bitcoin it's a minor fix as it doesn't cause any problems
but as we want to enable height verification from the beginning
we need to either fix cpp code or adjust BIP34 and fix tests.