[PR] Adding concepts clarification and tutorial by LuchoTurtle · Pull Request #2 · dwyl/learn-payment-processing

LuchoTurtle · 2022-12-21T19:32:14Z

closes #1

This PR should be the initial template for the project.
Has a section describing concepts for better understanding and a tutorial to follow through integration with Stripe.

README.md

LuchoTurtle · 2022-12-22T10:13:29Z

Even though it's still in progress, @nelsonic you can take a look at the "theory" part and check if there's anything big missing in it, before I start doing an example.
I didn't think going over the features of each alternative would be worthwhile from an engineering standpoint, as that is just marketing, imo.

LuchoTurtle · 2022-12-22T21:11:43Z

Added Stripe integration. It should be fully working, with authentication and checkout sessions.
I still want to expand the example more, though. Even though this works, I still want to block user access of unpaid users. Still need to see how that can be implemented with Stripe's API 🤔

nelsonic · 2022-12-23T09:32:03Z

Sounds good. keep going. looking forward to reading your research findings. 👌

mix.exs

README.md

…or not. #1

LuchoTurtle · 2022-12-28T17:19:05Z

This should be done. I've added the project, used DETS for storage (no need for PostgreSQL here) and I got it running with 100% coverage.

Fixed some README typos and changed the Fork example you mentioned in the feedback.

I also added CI (but it didn't execute in this PR).

nelsonic · 2022-12-31T07:28:55Z

nelsonic · 2023-01-03T07:27:37Z

README.md

+[That's a great question](https://www.indiehackers.com/post/stripe-vs-paddle-89161b0d5c).
+
+[Which seems to asked](https://splitbee.io/blog/why-we-moved-from-stripe-to-paddle)
+[over](https://stackshare.io/stackups/paddle-vs-stripe),


Please don't do this. [over] and [over] and [over] is not good link text. dwyl/contributing#119
I understand that you are emphasising the fact that many people have had these same questions.
But as a document that we want to read, maintain and have others contribute to.
We want to set high standards for link text.
Please/thanks! 🙏

nelsonic · 2023-01-03T13:23:29Z

** (Mix) Expected one or more files/patterns to be given to mix format or for a .formatter.exs file to exist with an :inputs or :subdirectories key

https://github.com/dwyl/learn-payment-processing/actions/runs/3828017445/jobs/6513143646

nelsonic · 2023-01-12T11:42:21Z

https://github.com/dwyl/learn-payment-processing/actions/runs/3901637053/jobs/6663723897#step:6:152

codecov · 2023-01-12T11:47:17Z

Codecov Report

❗ No coverage uploaded for pull request base (main@da457e4). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             main        #2   +/-   ##
========================================
  Coverage        ?   100.00%           
========================================
  Files           ?         9           
  Lines           ?        38           
  Branches        ?         0           
========================================
  Hits            ?        38           
  Misses          ?         0           
  Partials        ?         0

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

nelsonic

@LuchoTurtle this write-up is superb. 😍 Well done. 🎉

nelsonic · 2023-01-12T11:59:46Z

Note: I made a few tweaks but your core content is excellent. Keep up the great work. 🚀

LuchoTurtle added 2 commits December 21, 2022 18:06

feat: Adding payment processing concepts section. #1

bfcc1be

feat: Adding steps for Stripe account creation. #1

b67f406

LuchoTurtle added enhancement New feature or enhancement of existing functionality in-progress An issue or pull request that is being worked on by the assigned person epic A feature idea that is large enough to require a sprint (5 days) or more and has smaller sub-issues. labels Dec 21, 2022

LuchoTurtle self-assigned this Dec 21, 2022

nelsonic reviewed Dec 22, 2022

View reviewed changes

README.md Outdated Show resolved Hide resolved

LuchoTurtle added 5 commits December 22, 2022 10:15

fix: Switching Notion to Crunchyroll. #1

52e8e50

feat: Initial project commit. #1

f6b02c4

feat: Adding basic auth. #1

e8ba53a

fix: Making auth better. Prepping for Stripe. #1

5f26dae

feat: Adding Stripe integration. #1

f0a9e6e

nelsonic reviewed Dec 23, 2022

View reviewed changes

mix.exs Outdated Show resolved Hide resolved

LuchoTurtle added 5 commits December 23, 2022 13:18

feat: Installing ETS. #1

5cc8933

feat: Creating generic UserTable module with ETS. #1

6f20305

fix: Fixing UserTables functions. #1

555dbee

fix: Using Pockets to use DETS instead of ETS. #1

ab8c2b7

fix: Fixing table access when file already exists. #1

990444e

nelsonic reviewed Dec 25, 2022

View reviewed changes

README.md Outdated Show resolved Hide resolved

LuchoTurtle added 8 commits December 26, 2022 00:05

feat: Adding fetching user to check payment status. #1

0bfea37

feat: Showing button to purchase or enter depending if user has paid …

fca1a42

…or not. #1

feat: Finishing project tutorial. #1

7902505

fix: Removing mailer and ecto. #1

c75aa24

feat: Fixing test and adding UsersTable test. #1

584a317

feat: Adding tests for app_controller, auth_controller. #1

8209fed

feat: Adding tests to page_controller with mocking Stripe's services. #1

4b62332

feat: Adding tests to CheckoutSessionController. #1

5f9d1cf

LuchoTurtle added 2 commits December 28, 2022 17:14

fix: Removing Fork example with Postico 2. #1

f268808

feat: Adding CI. #1

81d6292

LuchoTurtle added awaiting-review An issue or pull request that needs to be reviewed and removed in-progress An issue or pull request that is being worked on by the assigned person labels Dec 28, 2022

LuchoTurtle assigned nelsonic Dec 28, 2022

LuchoTurtle requested a review from nelsonic December 28, 2022 17:19

LuchoTurtle removed their assignment Dec 28, 2022

nelsonic added in-review Issue or pull request that is currently being reviewed by the assigned person and removed awaiting-review An issue or pull request that needs to be reviewed labels Dec 30, 2022

nelsonic added 4 commits December 30, 2022 03:09

remove superfluous screenshot and fix typos #1

898ffc5

reduce "What?" section to make intro tighter #1

809708b

remove .DS_Store

9c8ad9f

revise Why? section to clarify Why we are writing this doc #1

ab4a420

nelsonic added 4 commits January 1, 2023 00:15

avoid hot-linking to MoR image in README.md #1

45ef565

add credit/debit cards section to README.md #1

ad30c01

move example/tutorial to separte doc #1

1e9ce4b

create formatter.exs to run mix format

b5fff40

nelsonic reviewed Jan 3, 2023

View reviewed changes

modify order of instructions in example.md for clarity #1

19a50ce

remove :ecto from .formatter.exs see: #2 (comment)

0dfcfe6

add brief explanation of why we are using "stripity-stripe" for #4 / #1

bbe6a8f

nelsonic approved these changes Jan 12, 2023

View reviewed changes

nelsonic merged commit 3110b40 into main Jan 12, 2023

nelsonic deleted the initial-implementation branch January 12, 2023 11:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[PR] Adding concepts clarification and tutorial#2

[PR] Adding concepts clarification and tutorial#2
nelsonic merged 35 commits intomainfrom
initial-implementation

LuchoTurtle commented Dec 21, 2022

Uh oh!

Uh oh!

LuchoTurtle commented Dec 22, 2022

Uh oh!

LuchoTurtle commented Dec 22, 2022

Uh oh!

nelsonic commented Dec 23, 2022

Uh oh!

Uh oh!

Uh oh!

LuchoTurtle commented Dec 28, 2022

Uh oh!

nelsonic commented Dec 31, 2022

Uh oh!

nelsonic Jan 3, 2023

Uh oh!

nelsonic commented Jan 3, 2023

Uh oh!

nelsonic commented Jan 12, 2023

Uh oh!

codecov bot commented Jan 12, 2023

Uh oh!

nelsonic left a comment

Uh oh!

nelsonic commented Jan 12, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

LuchoTurtle commented Dec 21, 2022

Uh oh!

Uh oh!

LuchoTurtle commented Dec 22, 2022

Uh oh!

LuchoTurtle commented Dec 22, 2022

Uh oh!

nelsonic commented Dec 23, 2022

Uh oh!

Uh oh!

Uh oh!

LuchoTurtle commented Dec 28, 2022

Uh oh!

nelsonic commented Dec 31, 2022

Uh oh!

nelsonic Jan 3, 2023

Choose a reason for hiding this comment

Uh oh!

nelsonic commented Jan 3, 2023

Uh oh!

nelsonic commented Jan 12, 2023

Uh oh!

codecov bot commented Jan 12, 2023

Codecov Report

Uh oh!

nelsonic left a comment

Choose a reason for hiding this comment

Uh oh!

nelsonic commented Jan 12, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants