chore: public readonly property for CandidFunc#130
Merged
Gekctek merged 3 commits intoedjCase:mainfrom Oct 21, 2024
Merged
Conversation
witter-s
force-pushed
the
feature/convert-CandidFunc-to-QueryRequest
branch
from
d8b260f to
6bf03af
Compare
witter-s
changed the title
Gekctek
requested changes
Oct 21, 2024
Collaborator
Gekctek
left a comment
Gekctek
left a comment
There was a problem hiding this comment.
See comment, would just make serviceInfo public and change it to 'ServiceInfo'
Gekctek
approved these changes
Oct 21, 2024
Collaborator
Gekctek
left a comment
Gekctek
left a comment
There was a problem hiding this comment.
Cansiter vs Canister
Goodness, maybe i need to get my eyes checked
Ty
Collaborator
|
@witter-deland |
witter-s
added a commit
to Deland-Labs/ICP.NET
that referenced
this pull request
Oct 24, 2024
* chore: CandidFunc public property * chore: remove new properties * fix: typo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #129