Skip to content

Fullscreen dialog#89

Merged
eltos merged 9 commits intomainfrom
fullscreen-dialog
Jul 31, 2023
Merged

Fullscreen dialog#89
eltos merged 9 commits intomainfrom
fullscreen-dialog

Conversation

@eltos
Copy link
Owner

@eltos eltos commented Jul 31, 2023

This PR introduces fullscreen dialogs as discussed in #87

A basic dialog

SimpleFormDialog.buildLogin("user", "password")
        .msg("Please login to continue")
        .show(this, "login_dialog_tag");

can be set to fullscreen by adding a single line:

SimpleFormDialog.buildLogin("user", "password")
        .msg("Please login to continue")
        .fullscreen() // <-- add this
        .show(this, "login_dialog_tag");

The primary use case are dialogs with a lot of content, or those that require keyboard input. In these cases, a basic dialog can quickly become confusing. This is especially true for Material 3 themes which have a lot of blank space around the dialogs:

Basic dialog Fullscreen dialog
grafik grafik
grafik grafik

closes #87

@eltos eltos self-assigned this Jul 31, 2023
@eltos eltos merged commit 1be515b into main Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Material3 Full-Screen Dialogs

1 participant