Skip to content

[ENHANCEMENT] Remove ember-fetch#10664

Merged
NullVoxPopuli merged 2 commits intomasterfrom
nvp/remove-ember-fetch
May 23, 2025
Merged

[ENHANCEMENT] Remove ember-fetch#10664
NullVoxPopuli merged 2 commits intomasterfrom
nvp/remove-ember-fetch

Conversation

@NullVoxPopuli
Copy link
Contributor

@NullVoxPopuli NullVoxPopuli commented Mar 11, 2025 •
edited
Loading

RFC: emberjs/rfcs#1065

Supersedes

Things folks can migrate to if they need to:

3 commands needed to update / rebase:

WRITE_FIXTURES=true pnpm test ./tests/acceptance/new-test.js
EMBER_CLI_ENABLE_ALL_EXPERIMENTS=true WRITE_FIXTURES=true pnpm test ./tests/acceptance/new-test.js
EMBER_CLI_EMBROIDER=true WRITE_FIXTURES=true pnpm test ./tests/acceptance/new-test.js

@NullVoxPopuli NullVoxPopuli changed the title [BUGFIX beta] Remove ember-fetch [ENHANCEMENT beta] Remove ember-fetch Mar 11, 2025
@Windvis
Copy link
Contributor

Windvis commented Mar 12, 2025

I think this line can also be removed now:

ember-cli/blueprints/addon/index.js

Line 82 in 487ae48

delete contents.devDependencies['ember-fetch'];

Also, I think the title is wrong since this shouldn't target the beta release?

@NullVoxPopuli NullVoxPopuli changed the base branch from master to beta March 12, 2025 12:10
@NullVoxPopuli
Copy link
Contributor Author

NullVoxPopuli commented Mar 12, 2025

Thanks! Now it targets beta

@NullVoxPopuli
Copy link
Contributor Author

NullVoxPopuli commented Mar 12, 2025

Cleaned up the addon blueprint

@kategengler kategengler mentioned this pull request Mar 14, 2025
Merged
10 tasks
@kategengler
Copy link
Member

kategengler commented Mar 14, 2025

This shouldn't merge until emberjs/rfcs#1081 is in Ready for Release stage

@kategengler kategengler changed the title [ENHANCEMENT beta] Remove ember-fetch [ENHANCEMENT] Remove ember-fetch Mar 14, 2025
@NullVoxPopuli NullVoxPopuli changed the base branch from beta to master March 14, 2025 19:03
@kategengler
Copy link
Member

kategengler commented Mar 14, 2025

Can you change the base to master? We don't backport enhancements, only bugfixes.

@NullVoxPopuli
Copy link
Contributor Author

NullVoxPopuli commented Mar 14, 2025

Can you change the base to master? We don't backport enhancements, only bugfixes.

done

@NullVoxPopuli NullVoxPopuli force-pushed the nvp/remove-ember-fetch branch from 4f28694 to 132c91d Compare April 4, 2025 18:51
@kategengler
Copy link
Member

kategengler commented Apr 7, 2025

This shouldn't merge until emberjs/rfcs#1081 is in Ready for Release stage

@NullVoxPopuli NullVoxPopuli force-pushed the nvp/remove-ember-fetch branch from 132c91d to 1dd2431 Compare May 21, 2025 15:57
@NullVoxPopuli NullVoxPopuli mentioned this pull request May 21, 2025
Open
@NullVoxPopuli
Update blueprints
cde2376 
Update fixtures

Update index.js
@NullVoxPopuli
Update fixtures
7ef1ada
@NullVoxPopuli NullVoxPopuli force-pushed the nvp/remove-ember-fetch branch from 1dd2431 to 7ef1ada Compare May 23, 2025 19:06
@NullVoxPopuli NullVoxPopuli mentioned this pull request May 23, 2025
Merged
3 tasks
@NullVoxPopuli NullVoxPopuli merged commit 4857a44 into master May 23, 2025
136 of 138 checks passed
@NullVoxPopuli NullVoxPopuli deleted the nvp/remove-ember-fetch branch May 23, 2025 20:15
@github-actions github-actions bot mentioned this pull request Jun 9, 2025
Merged
This was referenced Jun 11, 2025
Merged
Merged
@github-actions github-actions bot mentioned this pull request Jul 29, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bertdeblock bertdeblock bertdeblock approved these changes

@kategengler kategengler Awaiting requested review from kategengler

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@NullVoxPopuli @Windvis @kategengler @bertdeblock @mansona