testing: don't generate temp directories in the repo#10670
Merged
kategengler merged 2 commits intomasterfrom May 21, 2025
Merged
testing: don't generate temp directories in the repo#10670kategengler merged 2 commits intomasterfrom
kategengler merged 2 commits intomasterfrom
Conversation
kategengler
reviewed
Apr 28, 2025
kategengler
requested changes
Apr 28, 2025
kategengler
approved these changes
May 21, 2025
This was referenced Jun 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed this when I was trying to do a new feature that relies on resolving that if we generate our temp folders inside the checked out repo then we will have things being accidentally resolvable 🙈
This will also make test rely on system TEMP which I think is usually MemFS nowadays 🤔 so that would make things quicker 🎉