[BUGFIX] Remove deprecated @types/eslint__js dependency from app blueprint#10684
Merged
bertdeblock merged 1 commit intoember-cli:masterfrom Apr 11, 2025
Merged
Conversation
gvdp
force-pushed
the
fix/remove-deprecated-dependency
branch
from
22035ca to
d0e6298
Compare
bertdeblock
changed the title
@types/eslint__js dependency from app blueprint
gvdp
force-pushed
the
fix/remove-deprecated-dependency
branch
from
d0e6298 to
9f88acc
Compare
Contributor
Author
|
Updated the fixtures to also pass CI with the feature flags enabled. It was not clear to me from the Contributing.MD I had to update these as well, it just says Seems 2 other scenarios failed with a timeout for fetching dependencies: |
bertdeblock
approved these changes
Apr 11, 2025
NullVoxPopuli
approved these changes
Apr 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10683