run tests on the release-plan PR#10744
Merged
NullVoxPopuli merged 1 commit intomasterfrom Jul 21, 2025
Merged
Conversation
NullVoxPopuli
approved these changes
Jul 21, 2025
Closed
Merged
This was referenced Jul 23, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have a bit of a timing issue with our tests at the moment. Because we have a lot of fixtures that are checking against exact versions in a package.json output, and that package.json output is often driven by the version that is in the ember-cli.version
This means that, because the release-plan PRs actually bump versions we need to run our tests in the release-plan PR and also bump the fixture (we can do that automatically somehow)