Add new VITE experiment to generate app with new Vite blueprint#10781
Merged
mansona merged 8 commits intoember-cli:masterfrom Sep 5, 2025
Merged
Add new VITE experiment to generate app with new Vite blueprint#10781mansona merged 8 commits intoember-cli:masterfrom
VITE experiment to generate app with new Vite blueprint#10781mansona merged 8 commits intoember-cli:masterfrom
Conversation
04a7573 to
ee8ebdb
Compare
mansona
reviewed
Sep 1, 2025
ee8ebdb to
278ca47
Compare
1af4a1a to
a844fc5
Compare
a844fc5 to
325419d
Compare
ff41914 to
04b3c92
Compare
mansona
reviewed
Sep 3, 2025
4f257c1 to
95cda04
Compare
Merged
VITE experimentVITE experiment to generate app with new Vite blueprint
This was referenced Sep 7, 2025
Merged
ef4
reviewed
Sep 16, 2025
Contributor
ef4
left a comment
There was a problem hiding this comment.
Other than where I commented on OK skips, the rest of the skips probably shouldn't be skips.
Even when the vite experiment lands and we drop support for the v1 app blueprint, we're going to still have support for @embroider/compat which implies support for all these ember-cli features.
| }); | ||
|
|
||
| it('using autoRun: true', async function () { | ||
| if (isExperimentEnabled('VITE')) { |
Contributor
There was a problem hiding this comment.
This is ok to skip on vite because we make the app creation explicit.
| }); | ||
|
|
||
| it('using autoRun: false', async function () { | ||
| if (isExperimentEnabled('VITE')) { |
Contributor
There was a problem hiding this comment.
This is ok to skip on vite because we make the app creation explicit.
|
|
||
| // we dont run postprocessTree in embroider | ||
| if (!isExperimentEnabled('EMBROIDER')) { | ||
| if (!isExperimentEnabled('EMBROIDER') && !isExperimentEnabled('VITE')) { |
|
|
||
| it('init a single file', async function () { | ||
| if (DEPRECATIONS.INIT_TARGET_FILES.isRemoved) { | ||
| if (DEPRECATIONS.INIT_TARGET_FILES.isRemoved || isExperimentEnabled('VITE')) { |
Contributor
There was a problem hiding this comment.
All the skips where the test was already guarded by DEPRECATIONS.INIT_TARGET_FILES.isRemoved are OK.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I can and will split this into separate PRs if sensible, but I wanted to make sure everything is in place before I do.
experiments.mdember newto make them easier to read (and refactor / remove later)VITEwhich defaultsember newto the new@ember/app-blueprintblueprintember-cliand@ember/app-blueprintCloses #10771
This work is supported by the Mainmatter Ember Initiative.