update the format of the ember-cli-update.json#10791
Merged
Conversation
NullVoxPopuli
approved these changes
Sep 1, 2025
kategengler
reviewed
Sep 1, 2025
| "blueprints": [ | ||
| { | ||
| "name": "<%= blueprint %>", | ||
| "outputRepo": "https://github.com/ember-cli/ember-<%= blueprint === 'app' ? 'new' : 'addon' %>-output", |
Member
There was a problem hiding this comment.
It may not need to be here for ember-cli-update but we do need to make output repos for all the blueprints
kategengler
reviewed
Sep 1, 2025
| { | ||
| "name": "<%= blueprint %>", | ||
| "outputRepo": "https://github.com/ember-cli/ember-<%= blueprint === 'app' ? 'new' : 'addon' %>-output", | ||
| "codemodsSource": "ember-<%= blueprint %>-codemods-manifest@1", |
Member
There was a problem hiding this comment.
We probably do want a codemodsSource? This removes it for classic as well and so I don't believe ember-cli-update's run codemods will work without this.
They are kept here in a monorepo https://github.com/ember-cli/ember-cli-update-codemods-manifest/
This was referenced Sep 1, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fundamentally this PR fixes a problem that has been surfaced by #10766
We can now have a difference in versions between
ember-cliand the two app and addon blueprint packages. This means that expecting the app and addon blueprints to have a version the same as ember-cli is no longer valid.This also sets us up to correctly update people across the vite boundary to the "old blueprints" without to much trouble 👍