Even more dependency updates#10906
Merged
bertdeblock merged 3 commits intoember-cli:masterfrom Dec 20, 2025
Merged
Conversation
bertdeblock
commented
Dec 20, 2025
| return hash; | ||
| }, {}); | ||
| return globSync(pattern, { cwd: callerFileDir }) | ||
| .sort() |
Member
Author
There was a problem hiding this comment.
Previous version used to sort, but the newer version doesn't. We need sorting here, to keep the help output sorted as well.
bertdeblock
commented
Dec 20, 2025
| cwd: filePath, | ||
| dot: true, | ||
| mark: true, | ||
| strict: true, |
Member
Author
There was a problem hiding this comment.
strict option does not exist anymore.
bertdeblock
commented
Dec 20, 2025
| let optionOrFile = process.argv[2]; | ||
| // default to `tap` reporter in CI otherwise default to `spec` | ||
| let testFiles = glob.sync(`${root}/**/*-test.js`); | ||
| let testFiles = globSync(`${root}/**/*-test.js`).sort(); |
Member
Author
There was a problem hiding this comment.
pnpm test fails without sort() here, which isn't a good sign, but didn't feel like digging in tbh 😄
bertdeblock
commented
Dec 20, 2025
| this.availableOptions = this.availableOptions.concat(ClassicOptions); | ||
| } | ||
|
|
||
| // Make sure Testem supports the Wasm MIME type: |
Member
Author
There was a problem hiding this comment.
Not needed anymore, present by default.
kategengler
approved these changes
Dec 20, 2025
Merged
Merged
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.