add correct --publish-branch to pnpm publish#10952
Merged
Conversation
kategengler
reviewed
Feb 9, 2026
| run: | | ||
| if [ ${{ github.ref }} = "refs/heads/release" ]; then | ||
| pnpm release-plan publish | ||
| pnpm release-plan publish --publish-branch=release |
Member
There was a problem hiding this comment.
alternatively you could have three steps, one for each branch and have them conditional
Member
Author
There was a problem hiding this comment.
Yea I did consider that 🤔 I wasn't sure in terms of style, but also this shouldn't be needed at all 🙈 I almost feel like release-plan should just always pass --publish-branch to pnpm publish or do whatever is necessary to turn off this check
kategengler
approved these changes
Feb 9, 2026
This was referenced Feb 9, 2026
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should hopefully be the last PR required to fix deployment with OIDC 🙏 😭 🫠
Essentially we missed a bunch of subtleties in the deleted files in #10950
--publish-branch=<branch-name>--github-prereleaseThat means that we need an if/elif block that has a different behaviour for all 3 branches that we deploy from 🙈 But this should do it 👍