fix: clear relationships properly when unloading new records#8791
Merged
runspired merged 4 commits intowarp-drive-data:mainfrom Aug 27, 2023
Merged
Conversation
runspired
reviewed
Aug 26, 2023
runspired
force-pushed
the
fix/rollback-new-related-records
branch
from
3ae43de to
db1efc8
Compare
Unloading a new record that is related to another record does not remove it from the relationship.
runspired
force-pushed
the
fix/rollback-new-related-records
branch
from
f2afc14 to
373a096
Compare
runspired
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Unloading a new record that is related to another record does not remove it from the relationships. This then causes issues if the other record also is unloaded or if code expects the relationships to no longer include the unloaded record. This adds a failing test case.
This behavior seems to have changed in EmberData v4.7+, older versions seemingly work as expected.
Related Discord thread: https://discord.com/channels/480462759797063690/1143193491250368583
Similar issue: #8262