Conversation
runspired
added
🎯 canary
runspired
commented
Sep 18, 2023
| const url = buildBaseURL(urlOptions); | ||
| const headers = new Headers(); | ||
| headers.append('Content-Type', 'application/json; charset=utf-8'); | ||
| headers.append('Accept', 'application/json; charset=utf-8'); |
Contributor
Author
There was a problem hiding this comment.
I removed Content-Type from the builders because we want the out-of-the-box CORS experience to be great, and CORS only allows Content-Type to be application/x-www-form-urlencoded multipart/form-data or text/plain before it will opt for a preflight request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
@ember-data/mock-server, a private (for now) mock-server based on real HTTP requests.The mock server can integrate with any app's test suite via an additional handler and a simple beforeEach/afterEach setup.
The mock server has the ability to both record and replay. Once a recording exists, replaying is extremely cheap due to http/2, careful mitigation of CORS pre-flighting, and all requests having been pre-compressed with brotli at 11.
Currently all mocking is done within the app and posted to the server.