Skip to content

fix: live-array delete sync should not clear the set on length match#8927

Merged
runspired merged 3 commits intomainfrom
main-unload-all
Sep 28, 2023
Merged

fix: live-array delete sync should not clear the set on length match#8927
runspired merged 3 commits intomainfrom
main-unload-all

Conversation

@runspired
Copy link
Contributor

@runspired runspired commented Sep 27, 2023 •
edited
Loading

test from #8926
resolves #8924

adds test for unloadAll not fully cleaning up

The rough issue is that if all records are removed and the same number re-added before the array has synced we were then fully clearing membership which would make the next sync after this fail to work properly.

e.g.

arr.length; // 2
arrSet.size; // 2
<add> C
<add> D
<rem> A
<rem> B

if (rem.length === arr.length) { arrSet.clear() }

arr.length; // 2
arrSet.size; // 0

@runspired runspired added 🎯 canary PR is targeting canary (default) 🏷️ bug This PR primarily fixes a reported issue labels Sep 27, 2023
@runspired runspired changed the title fix: add test for unloadAll not fully cleaning up fix: live-array delete sync should not clear the set on length match Sep 28, 2023
@runspired runspired merged commit d8f5fd7 into main Sep 28, 2023
@delete-merged-branch delete-merged-branch bot deleted the main-unload-all branch September 28, 2023 04:58
@runspired runspired added 🎯 release PR should be backported to release 🎯 lts The PR should be backported to the most recent LTS labels Sep 28, 2023
runspired added a commit that referenced this pull request Sep 28, 2023
@runspired
fix: live-array delete sync should not clear the set on length match (#…
031b770 
…8927)

* fix: add test for unloadAll not fully cleaning up

* fix

* fix lint
runspired added a commit that referenced this pull request Sep 28, 2023
@runspired
fix: live-array delete sync should not clear the set on length match (#…
7ec8f28 
…8927)

* fix: add test for unloadAll not fully cleaning up

* fix

* fix lint
@runspired runspired mentioned this pull request Sep 28, 2023
Merged
runspired added a commit that referenced this pull request Sep 28, 2023
@runspired
fix: live-array delete sync should not clear the set on length match (#…
7c5c65a 
…8927) (#8926)

* fix: add test for unloadAll not fully cleaning up

* fix

* fix lint
runspired added a commit that referenced this pull request Sep 28, 2023
@runspired
fix: live-array delete sync should not clear the set on length match (#…
23541f6 
…8927) (#8929)

* fix: add test for unloadAll not fully cleaning up

* fix

* fix lint
@gitKrystan gitKrystan mentioned this pull request Dec 6, 2023
Closed
3 tasks
@gitKrystan gitKrystan mentioned this pull request Jan 9, 2024
Merged
@gitKrystan gitKrystan mentioned this pull request Jan 16, 2024
Merged
This was referenced Apr 29, 2024
Merged
Merged
@gitKrystan gitKrystan mentioned this pull request Feb 3, 2025
Closed
@gitKrystan gitKrystan mentioned this pull request Feb 11, 2025
Merged
@gitKrystan gitKrystan mentioned this pull request Apr 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

🎯 canary PR is targeting canary (default) 🎯 lts The PR should be backported to the most recent LTS 🎯 release PR should be backported to release 🏷️ bug This PR primarily fixes a reported issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[4.12.3] Bug: Loading / unloading the same resource multiple times results in lingering reference in cache

1 participant

@runspired