fix: make willCommit slightly safer when race conditions occur#9012
Merged
fix: make willCommit slightly safer when race conditions occur#9012
Conversation
runspired
added
🏷️ bug
runspired
force-pushed
the
fix-will-commit
branch
from
580de48 to
46c36a1
Compare
3 tasks
This was referenced Apr 29, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the timing changes in 4.12 made this race condition slightly easier to hit. The approach here is still "known to be buggy" but results in less potential information loss.