feat (internal): support legacy model behaviors in SchemaRecord legacy mode#9095
Merged
feat (internal): support legacy model behaviors in SchemaRecord legacy mode#9095
Conversation
runspired
added
🎯 canary
runspired
force-pushed
the
schema-record/legacy-features
branch
from
1f3eeec to
fdcb483
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests
TBD
Note: only superficially tested. We're largely just copying model code over in a non-diverging manner so as long as the basic mechanics work we should be fine. So for instance we don't need to test every behavior around state flags.