Conversation
async is not necessary
runspired
commented
Dec 4, 2023
| self[MUTATE]!(prop as string, args, result); | ||
| addToTransaction(_TAG); | ||
| // TODO handle cache updates | ||
| const result = self[MUTATE]!(target, receiver, prop as string, args, _TAG); |
Contributor
Author
There was a problem hiding this comment.
one thing I've been constantly debating around this line is whether we should try/finally it to ensure transaction is set back to false if we error.
3 tasks
This was referenced Jan 3, 2024
This was referenced Apr 29, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #9119
New Tests
Graph Tests (we will likely want these in 5.3 version of this, but not necessarily)
Model/Main Tests