Skip to content

feat: implement managed array for schemaRecord#9240

Merged
runspired merged 8 commits intomainfrom
richgt/schema-array
Mar 18, 2024
Merged

feat: implement managed array for schemaRecord#9240
runspired merged 8 commits intomainfrom
richgt/schema-array

Conversation

@richgt
Copy link
Contributor

@richgt richgt commented Feb 29, 2024

Adds support for simple autotracked arrays to schema-record.

basic schema:

{
  name: 'favoriteNumbers',
  type: null,
  kind: 'array',
},

per-item transformation is supported:

 {
  name: 'favoriteNumbers',
  type: 'string-from-int',
  kind: 'array',
}

The fields will appear and act as native arrays.

@richgt richgt force-pushed the richgt/schema-array branch from 4adda74 to 26828c9 Compare February 29, 2024 19:33
@richgt richgt requested a review from runspired March 13, 2024 14:49
@richgt richgt force-pushed the richgt/schema-array branch from 26828c9 to fa06e42 Compare March 15, 2024 16:21
@runspired runspired added 🎯 canary PR is targeting canary (default) 🏷️ feat This PR introduces a new feature labels Mar 18, 2024
@runspired runspired changed the title implement managed array for schemaRecord feat: implement managed array for schemaRecord Mar 18, 2024
@runspired runspired marked this pull request as ready for review March 18, 2024 23:41
Copy link
Contributor

@runspired runspired left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In follow up we should add tests around recoverability/behavior if the transform errors on item insertion / an out-of-bounds index set or length set occurs.

@runspired runspired merged commit 40fa283 into main Mar 18, 2024
@runspired runspired deleted the richgt/schema-array branch March 18, 2024 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🎯 canary PR is targeting canary (default) 🏷️ feat This PR introduces a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants