doc: don't mention unexisting ESA auth handler#9275
Merged
Conversation
I think this could be confusing, and unless I miss something such handler does not exist, and I didn't see any open issue/PR in the ESA repo mentionning it
sly7-7
changed the title
runspired
approved these changes
Mar 22, 2024
Contributor
runspired
left a comment
runspired
left a comment
There was a problem hiding this comment.
yeah I put this there as an example, as this is what ESA should refactor to do vs the approach it uses today. Thanks!
runspired
added
🎯 canary
sly7-7
added a commit
that referenced
this pull request
Mar 28, 2024
runspired
pushed a commit
that referenced
this pull request
Apr 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I think this could be confusing, and unless I miss something such handler does not exist, and I didn't see any open issue/PR in the ESA repo mentionning it