Conversation
gitKrystan
commented
Apr 10, 2024
gitKrystan
commented
Apr 10, 2024
| } | ||
|
|
||
| // prettier-ignore | ||
| runTests( |
Contributor
Author
There was a problem hiding this comment.
jscodeshift's default testing setup is missing some features, so I wrote my own.
For each codemod, we can add a folder in __testfixtures__ with the dasherized codemod name, and this test setup will run that codemod against all of the files contained therein. testName.input.ts will be modded and the result will be compared with testName.output.ts. You can also add testName.info.json with other useful stuff (e.g. config--not set up yet--or expected log output--see e.g. below).
example:
// testName.info.json
{
"expectedLogs": [
[
"warn",
"oh noes"
],
]
}
gitKrystan
commented
Apr 25, 2024
It was just spewing errors
They're unnecessary and cause a syntax error
We can infer request types from builders now. yay
gitKrystan
commented
May 1, 2024
packages/codemods/src/legacy-compat-builders/legacy-store-method.ts
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A new package for EmberData codemods. The first will be the
legacy-compat-builderscodemod to convertconst foo = await store.findRecord('foo', '1')toconst { content: foo } = await store.request(findRecord('foo', '1'), etc.Description
Notes for the release